Jason Ekstrand <ja...@jlekstrand.net> writes: I see two styles here -- get_physical_device_display_properties* both use a helper function that takes a pointer to either of the property returns while get_physical_device_display_plane_properties* and get_display_mode_properties* open-code things.
I'm easy with which style you pick, but I think they should be the same. I have a mild preference for the second style as I think it's easier to read the code without all of the conditionals. As for the actual implementation of each function, it looks good, so I'll actually mark this as Reviewed-by: Keith Packard <kei...@keithp.com> If you want to rework the first bit, I'll review whatever changes you make. If you just want to rebase and push, you've got my Rb above :-) -- -keith
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
