it turned out that the failures with GATHER*O were the result of a faulty optimization done by sb. So for consistensy I'll also add the offset for GATHER4_O and GATHER4_C_O in the SET_TEXTURE_OFFSET call which alleviates the problems with sb.
Apart from that I've just fixed some comments following Roland's remarks. I ran the dEQP GLES 2, 3, and 31 suites and piglit run gpu -t texture -t gather I didn't see any regressions, but textureSize 140 tes sampler2DArrayShadow -auto -fbo seems to be unstable. It usually passes, but once in a while it fails (on both, master and with this patch applied) Best, Gert Gert Wollny (2): r600: correct texture offset for array index lookup r600: set rounding mode for texture array layer selection src/gallium/drivers/r600/evergreen_state.c | 23 +++++++++++++++++++++++ src/gallium/drivers/r600/r600_shader.c | 29 +++++++++++++++++++++++++++-- 2 files changed, 50 insertions(+), 2 deletions(-) -- 2.16.4 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev