On Thu, Jul 5, 2018 at 7:42 AM Lionel Landwerlin <lionel.g.landwer...@intel.com> wrote: > > Older system might not have support for memfd_create at the kernel > level. There we won't be able to use aubinator. > > We also initially tried to workaround some libc having the > memfd_create syscall number defined, but not the memfd_create() > function. > > This change fixes the broken build on the travis CI by only compiling > aubinator if memfd_create() is available as part of the libc.
memfd_create() was added in glibc-2.27. I think that's too new to rely on. I know aubinator is a developer tool, but I don't think most developers have glibc 2.27 yet. I'd suggest we rename our "memfd_create" functions to avoid the clash with glibc-2.27+ and just use them regardless. > Annoyingly the man page says which should include <sys/memfd.h> but It doesn't exist in upstream glibc either. I think the man page is simply wrong. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
