On Saturday, July 7, 2018 12:04:35 PM PDT Kenneth Graunke wrote:
> On Saturday, July 7, 2018 6:08:34 AM PDT Lionel Landwerlin wrote:
> > Fixes: 7987d041fda0c9 ("i965/surface_state: Emit the clear color address
> > instead of value.")
> > Signed-off-by: Lionel Landwerlin <[email protected]>
> > ---
> > src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > index 73cae9ef7c5..9397b637c79 100644
> > --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > @@ -220,7 +220,7 @@ brw_emit_surface_state(struct brw_context *brw,
> > if (clear_bo != NULL) {
> > /* Make sure the offset is aligned with a cacheline. */
> > assert((clear_offset & 0x3f) == 0);
> > - uint32_t *clear_address =
> > + uint64_t *clear_address =
> > state + brw->isl_dev.ss.clear_color_state_offset;
> > *clear_address = brw_state_reloc(&brw->batch,
> > *surf_offset +
> >
>
> Oh geez. I thought I audited for all of these, but this one must have
> been out of tree at the time and crept in...or somehow I missed it.
>
> Sorry about that, it must've been annoying to track down. :(
>
> Reviewed-by: Kenneth Graunke <[email protected]>
> It looks like blorp_genX_exec.h:1381 has the exact same bug. Feel free to fix that one as well and keep my R-b :)
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
