On 18 July 2018 at 19:34, Eric Anholt <e...@anholt.net> wrote: > Emil Velikov <emil.l.veli...@gmail.com> writes: > >> From: Emil Velikov <emil.veli...@collabora.com> >> >> With commit c6c0f947142, back in 2006 Brian removed the >> _glapi_check_multithread() call from core mesa - _mesa_make_current. >> >> He moved it to a DRI loader (type of) decision - with equivalents in >> the monolithic OSMesa and libGL-Xlib. >> >> Some time afterwords, swrast (a DRI driver) was introduced as a copy >> paste of the latter two. Remove the call since the DRI loader handles >> that for us. >> >> Signed-off-by: Emil Velikov <emil.veli...@collabora.com> > > Does anything make sure it gets called for classic drivers under EGL? > Good call - I cannot spot anything. Which means that all classic drivers, but swrast is foobar'd. Gallium itself calls _glapi_check_multithread so those drivers are safe.
> Actually, wouldn't it make sense to move this back to the core, at this > point? Since glapi is fiddly, I've opted for the least invasive patch. Moving the call to core would be better, indeed. -Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
