Hi Emil,
On 24.07.18 19:23, Emil Velikov wrote:
Hi Danylo,
Having a closer look inspired by Eric's comments
On 24 July 2018 at 15:37, Danylo Piliaiev <danylo.pilia...@gmail.com> wrote:
Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler.
As you bump the libdrm version:
- drop the existing DRM_EVENT_CONTEXT_VERSION guard
- swap the DRM_EVENT_CONTEXT_VERSION macro with the actual version implemented
Makes sense, will be done.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107170
https://bugs.freedesktop.org/show_bug.cgi?id=106972
https://bugs.freedesktop.org/show_bug.cgi?id=107176
Separate bugs it seems - hence separate patches?
Yes
+LIBDRM_CRT_SEQUENCE_REQUIRED=2.4.89
+
There is no need for yet another version - just bump LIBDRM_REQUIRED.
Bumping LIBDRM_REQUIRED would mean that older platforms won't be supported.
I don't know how the decisions about support of older platforms are made but
from my point of view bumping required libdrm version due to one vulkan
extension
may be overkill.
If we consider this as the only merit, then the number of
checks/version would practically explore.
Simply take each user libGL, libEGL, gbm, other multiply that with the
number of features we use.
Looking at Eero's bug (last one in the list) - he's using Ubuntu 16.04
which has 2.4.91 in xenial-updates
I didn't notice that libdrm is easy to update thus my argument fails.
Managing dependencies is hard...
Why do we need the new define? From a quick look we should be above to
reuse VK_USE_PLATFORM_DISPLAY_KHR, we simply need the ifdef guards.
If we will not bump global libdrm version requirement new define is
necessary because
rest of the code guarded by VK_USE_PLATFORM_DISPLAY_KHR works fine with
older libdrm versions.
And by addressing that, this can go - one diverging codepath less ;-)
For good.
HTH
Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
