On Wed, Jul 25, 2018 at 6:50 AM, Rob Herring <r...@kernel.org> wrote: > On Tue, Jul 24, 2018 at 5:21 PM John Stultz <john.stu...@linaro.org> wrote: >> >> From: Yong Yao <yong....@intel.com> >> >> This is a forward port of a patch from the AOSP/master branch: >> https://android.googlesource.com/platform/external/mesa3d/+/b1e5fad1db4c1d51c7ae3a033b100a8429ae5415%5E%21/ >> >> Which allows boards to provide their own custom copy of mesa. > > IMO, if AOSP wants/needs to have multiple forks of mesa, then they > should carry this patch.
I'd turn this around and ask if there is any sense in having the default mesa in AOSP be anything but (possibly a stable snapshot) of the upstream mesa tree? Obviously, shipping boards/devices will need their own device specific hacks and patches until those go upstream, so this provides a mechanism for that. But if vendors can't easily test upstream mesa (hopefully updated with their refined patches finally merged) with AOSP, that just creates an extra barrier, and dis-incentivises folks from bothering to work with upstream. thanks -john _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev