Hi Vadym, Ken and Ian explained a bit the situation on this one to me, and it looks like neither of them are really against this patch. So unless someone else raise any concern, I'll ack and push the patch later today.
Thanks for fixing this. Rafael On Thu, Jul 26, 2018 at 04:04:29PM +0300, Vadym Shovkoplias wrote: > ping > > On Tue, Jul 3, 2018 at 5:09 PM, Vadim Shovkoplias > <vadim.shovkopl...@gmail.com> > wrote: > > Hi mesa devs, > > Can anyone please review this ? > This patch fixes following bugs: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104388 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106158 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106667 > > > 2018-06-07 18:27 GMT+03:00 Vadim Shovkoplias > <vadim.shovkopl...@gmail.com>: > > Hi Kenneth, > > Can you please look at this patch ? > > 2018-06-07 15:30 GMT+03:00 Den <den.kos...@gmail.com>: > > Hello. Found out that this patch also fixes 2 new issues: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106158 > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106667 > > Tested-by: Denis <denys.kos...@globallogic.com> > > > > On 24.05.18 14:16, vadym.shovkoplias wrote: > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104388 > Signed-off-by: Andriy Khulap <andriy.khu...@globallogic.com> > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 11 > +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/ > src/mesa/drivers/dri/i965/genX_state_upload.c > index b485e2c..5aa8033 100644 > --- a/src/mesa/drivers/dri/i965/genX_state_upload.c > +++ b/src/mesa/drivers/dri/i965/genX_state_upload.c > @@ -2473,6 +2473,17 @@ brw_calculate_guardband_size(uint32_t > fb_width, uint32_t fb_height, > */ > const float gb_size = GEN_GEN >= 7 ? 16384.0f : 8192.0f; > + /* Workaround: prevent gpu hangs on SandyBridge > + * by disabling guardband clipping for odd dimensions. > + */ > + if (GEN_GEN == 6 && (fb_width & 1 || fb_height & 1)) { > + *xmin = -1.0f; > + *xmax = 1.0f; > + *ymin = -1.0f; > + *ymax = 1.0f; > + return; > + } > + > if (m00 != 0 && m11 != 0) { > /* First, we compute the screen-space render area */ > const float ss_ra_xmin = MIN3( 0, m30 + m00, > m30 > - m00); > > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > > > > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev > > > > > > -- > > Vadym Shovkoplias | Senior Software Engineer > GlobalLogic > P +380.57.766.7667 M +3.8050.931.7304 S vadym.shovkoplias > www.globallogic.com > > http://www.globallogic.com/email_disclaimer.txt _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
