I've sent comments on patches 3 & 4. With those addressed, patches 1-5 are:
Reviewed-by: Marek Olšák <marek.ol...@amd.com>
On Sat, Aug 18, 2018 at 7:16 AM Kai Wasserbäch
<k...@dev.carbon-project.org> wrote:
>
> Only used, when asserts are enabled.
>
> Fixes an unused-but-set-variable warning with GCC 8:
> ../../../src/amd/addrlib/r800/egbaddrlib.cpp: In member function 'virtual
> long long unsigned int
> Addr::V1::EgBasedLib::HwlGetSizeAdjustmentMicroTiled(unsigned int, unsigned
> int, ADDR_SURFACE_FLAGS, unsigned int, unsigned int, unsigned int, unsigned
> int*, unsigned int*) const':
> ../../../src/amd/addrlib/r800/egbaddrlib.cpp:4111:13: warning: variable
> 'physicalSliceSize' set but not used [-Wunused-but-set-variable]
> UINT_64 physicalSliceSize;
> ^~~~~~~~~~~~~~~~~
>
> Cc: Marek Olšák <mar...@gmail.com>
> Signed-off-by: Kai Wasserbäch <k...@dev.carbon-project.org>
> ---
> src/amd/addrlib/r800/egbaddrlib.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/addrlib/r800/egbaddrlib.cpp
> b/src/amd/addrlib/r800/egbaddrlib.cpp
> index 37a60c7a85..edc7a13070 100644
> --- a/src/amd/addrlib/r800/egbaddrlib.cpp
> +++ b/src/amd/addrlib/r800/egbaddrlib.cpp
> @@ -4110,7 +4110,7 @@ UINT_64 EgBasedLib::HwlGetSizeAdjustmentMicroTiled(
> ) const
> {
> UINT_64 logicalSliceSize;
> - UINT_64 physicalSliceSize;
> + MAYBE_UNUSED UINT_64 physicalSliceSize;
>
> UINT_32 pitch = *pPitch;
> UINT_32 height = *pHeight;
> --
> 2.18.0
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
