Quoting Lionel Landwerlin (2018-09-04 05:22:31) > On 04/09/2018 11:46, Sergii Romantsov wrote: > > Seems in case of 32-bit library, usage of msse2 makes > > some stack corruption or incorrect instructions. > > Usage with mstackrealign fixes that case. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779 > > Signed-off-by: Sergii Romantsov <[email protected]> > > --- > > src/mesa/drivers/dri/i965/Makefile.am | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/mesa/drivers/dri/i965/Makefile.am > > b/src/mesa/drivers/dri/i965/Makefile.am > > index 889d4c6..0afa7a2 100644 > > --- a/src/mesa/drivers/dri/i965/Makefile.am > > +++ b/src/mesa/drivers/dri/i965/Makefile.am > > @@ -44,7 +44,7 @@ AM_CFLAGS = \ > > $(WNO_OVERRIDE_INIT) \ > > $(LIBDRM_CFLAGS) \ > > $(VALGRIND_CFLAGS) \ > > - -msse2 > > + -msse2 -mstackrealign > > > > AM_CXXFLAGS = $(AM_CFLAGS) > > > > Hey Sergii, > > Thanks a lot for looking into this issue. > I think you might need to update the other build systems (Android.mk/meson). > > The toplevel meson/makefile have a -mstackrealign that seem to make the > description of the issue you're fixing. > Maybe that's where this change should go. > > Thanks, > > - > Lionel
There's a similar usage in anv that should be fixed. My reading of the gcc man page and Matt's understanding is that -mstackrealign is a no-op on x86_64, so just putting it in there should be fine. For meson it might be nice to add a c_sse2_args = ['-msse2', '-mstackrealign'] at the src/intel level and use instead of adding -mstackrealign everywhere, but we can also do that as a follow-up. Dylan
signature.asc
Description: signature
_______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
