On Wednesday, 2018-09-05 11:51:48 -0700, Dylan Baker wrote: > This is out of my series to add meson support for non-cygwin windows. Since > that's been kinda slow to review and this seems like a good cleanup in > general, > I thought I'd send this out separately.
Sounds reasonable, and I glanced through and didn't see any glaring mistake, but that's not a full review, so a simple: Acked-by: Eric Engestrom <eric.engest...@intel.com> > > Dylan Baker (2): > move u_math to src/util > Replace uses of _mesa_bitcount with util_bitcount > > src/broadcom/cle/v3d_packet_helpers.h | 2 +- > src/compiler/glsl/ir_constant_expression.cpp | 2 +- > src/compiler/glsl/ir_expression_operation.py | 2 +- > src/compiler/glsl/link_varyings.cpp | 5 ++- > src/compiler/glsl/linker.cpp | 9 +++-- > src/compiler/nir/nir.c | 6 +-- > src/gallium/auxiliary/Makefile.sources | 2 - > src/gallium/auxiliary/meson.build | 2 - > src/gallium/auxiliary/util/u_format.c | 2 +- > src/gallium/auxiliary/util/u_format_bptc.c | 2 +- > src/gallium/auxiliary/util/u_format_latc.c | 2 +- > src/gallium/auxiliary/util/u_format_other.c | 2 +- > src/gallium/auxiliary/util/u_format_pack.py | 2 +- > src/gallium/auxiliary/util/u_format_rgtc.c | 2 +- > src/gallium/auxiliary/util/u_format_s3tc.c | 2 +- > src/gallium/auxiliary/util/u_format_yuv.h | 2 +- > src/gallium/auxiliary/util/u_format_zs.c | 2 +- > src/gallium/state_trackers/glx/xlib/glx_api.c | 7 ++-- > src/gallium/state_trackers/glx/xlib/xm_api.c | 11 +++--- > src/gallium/targets/libgl-xlib/Makefile.am | 1 + > src/intel/blorp/blorp_blit.c | 5 ++- > src/intel/compiler/brw_fs.cpp | 3 +- > src/intel/compiler/brw_fs_nir.cpp | 3 +- > src/intel/compiler/brw_nir.c | 5 ++- > src/intel/compiler/brw_vec4.cpp | 3 +- > src/intel/compiler/brw_vec4_visitor.cpp | 3 +- > src/intel/vulkan/anv_blorp.c | 2 +- > src/intel/vulkan/anv_image.c | 9 +++-- > src/intel/vulkan/anv_nir_lower_multiview.c | 8 ++-- > src/intel/vulkan/anv_pipeline.c | 2 +- > src/intel/vulkan/anv_private.h | 7 ++-- > src/intel/vulkan/genX_cmd_buffer.c | 4 +- > src/intel/vulkan/genX_query.c | 14 +++---- > src/mesa/drivers/common/meta.c | 5 ++- > src/mesa/drivers/dri/i965/brw_curbe.c | 3 +- > src/mesa/drivers/dri/i965/brw_draw_upload.c | 3 +- > .../drivers/dri/i965/brw_performance_query.c | 5 ++- > src/mesa/drivers/dri/i965/brw_wm.c | 7 ++-- > src/mesa/drivers/x11/Makefile.am | 1 + > src/mesa/drivers/x11/fakeglx.c | 7 ++-- > src/mesa/drivers/x11/meson.build | 2 +- > src/mesa/drivers/x11/xm_api.c | 17 +++++---- > src/mesa/main/arrayobj.c | 5 ++- > src/mesa/main/buffers.c | 7 ++-- > src/mesa/main/imports.c | 38 ------------------- > src/mesa/main/imports.h | 15 -------- > src/mesa/program/program_parse.y | 4 +- > src/util/Makefile.sources | 2 + > src/util/meson.build | 2 + > src/{gallium/auxiliary => }/util/u_math.c | 0 > src/{gallium/auxiliary => }/util/u_math.h | 2 +- > 51 files changed, 116 insertions(+), 144 deletions(-) > rename src/{gallium/auxiliary => }/util/u_math.c (100%) > rename src/{gallium/auxiliary => }/util/u_math.h (99%) > > -- > 2.18.0 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev