On to., sep. 6, 2018 at 3:00 PM, Emil Velikov <[email protected]> wrote:
Hi Erik,

On 6 September 2018 at 11:48, Erik Faye-Lund
<[email protected]> wrote:
If we end up never taking the loop that writes ret, we can end up with an uninitialized value, and if we're *really* unlucky, that value can be -1, causing us to go down an error-path instead of a success path.

This was obviously not intended, so let's just initialize this to zero.

Not that versed in virgl to know if one should initialize to 0 or 1.

The way I read the code, any value that isn't -1 will do, as that avoids us from going down the error-path.


In either case please use the following tag.
Should help with picking this fix to the right stable branches.

Fixes: a8987b88ff1 ("virgl: add driver for virtio-gpu 3D (v2)")

Thanks, fixed locally.


HTH
Emil
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to