Hi, On Thursday, 6 September 2018 23:43:41 CEST Roland Scheidegger wrote: > Looks alright to me, albeit seems a bit weird your hw can have offset of > 255 but only max stride of 128 - max offset being larger than max stride > doesn't really make a whole lot of sense. (Could you handle stride 255 > maybe?)
Yes, I have been looking at the the bitfields in the driver and the 255 is what the offset can set in terms of bits. And the stride would be 255 as well in that terms. The point here is to provide etnaviv with realtive offsets within their hardwares bounds. I will leave raising the stride value to something higher to the guys that know etnaviv better than me. Means I was wondering about the 128 too and thought it may have a reason that I don't see immediately. > I think in d3d10 these properties are intrinsically tied together, the > max struct size can be 2048, so this dictates both the max stride (2048) > as well as the max offset (2047 if it's a 8bit value). Not so > coincidentally, these values are also the required minimum values of > newer GL versions. Then again there's hw like r600 which can only > support 2047 in reality for stride, at least natively... Might even be > common that hw uses the same field width for stride as well as offsets... > > In any case, > Reviewed-by: Roland Scheidegger <[email protected]> Thanks! best Mathias _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
