Assuming you pass the CTS tests (which I'm pretty sure you do),

Reviewed-by: Jason Ekstrand <ja...@jlekstrand.net>

Mind reviewing mine?

On Mon, Sep 10, 2018 at 1:35 PM Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
wrote:

> ---
>  src/amd/vulkan/radv_device.c      | 7 +++++++
>  src/amd/vulkan/radv_extensions.py | 2 +-
>  2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 53f99a8cecd..7917ed7ffe5 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -821,6 +821,13 @@ void radv_GetPhysicalDeviceFeatures2(
>                         features->inheritedConditionalRendering = false;
>                         break;
>                 }
> +               case
> VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_VERTEX_ATTRIBUTE_DIVISOR_FEATURES_EXT: {
> +                       VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT
> *features =
> +
>  (VkPhysicalDeviceVertexAttributeDivisorFeaturesEXT *)ext;
> +                       features->vertexAttributeInstanceRateDivisor =
> VK_TRUE;
> +                       features->vertexAttributeInstanceRateZeroDivisor =
> VK_TRUE;
> +                       break;
> +               }
>                 default:
>                         break;
>                 }
> diff --git a/src/amd/vulkan/radv_extensions.py
> b/src/amd/vulkan/radv_extensions.py
> index b5b9c137927..fa35aabd3ba 100644
> --- a/src/amd/vulkan/radv_extensions.py
> +++ b/src/amd/vulkan/radv_extensions.py
> @@ -105,7 +105,7 @@ EXTENSIONS = [
>      Extension('VK_EXT_sampler_filter_minmax',             1,
> 'device->rad_info.chip_class >= CIK'),
>      Extension('VK_EXT_shader_viewport_index_layer',       1, True),
>      Extension('VK_EXT_shader_stencil_export',             1, True),
> -    Extension('VK_EXT_vertex_attribute_divisor',          2, True),
> +    Extension('VK_EXT_vertex_attribute_divisor',          3, True),
>      Extension('VK_AMD_draw_indirect_count',               1, True),
>      Extension('VK_AMD_gcn_shader',                        1, True),
>      Extension('VK_AMD_rasterization_order',               1,
> 'device->has_out_of_order_rast'),
> --
> 2.18.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to