+Cc Keith, Jason & Daniel, who know this code best. On Monday, 2018-09-24 08:46:22 +1000, Stuart Young wrote: > From: Maxime <[email protected]> > > Since the Randr lease code was added, compiling against libxcb 1.12 no > longer works. > > CC: [email protected] > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108024 > Fixes: 7ab1fffcd2a504024b16e408de329f7a94553ecc
Thanks for the `Fixes:` tag, it's really useful :) We usually also add the commit title as well, to help humans know what it's about without having to look it up (makes no difference to scripts though): Fixes: 7ab1fffcd2a504024b16 "vulkan: Add EXT_acquire_xlib_display [v5]" > Tested-By: Maxime <[email protected]> > > --- > src/vulkan/wsi/wsi_common_display.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/vulkan/wsi/wsi_common_display.c > b/src/vulkan/wsi/wsi_common_display.c > index e99b0465ec..e23d2983c9 100644 > --- a/src/vulkan/wsi/wsi_common_display.c > +++ b/src/vulkan/wsi/wsi_common_display.c > @@ -2304,6 +2304,7 @@ wsi_acquire_xlib_display(VkPhysicalDevice > physical_device, > if (!crtc) > return VK_ERROR_INITIALIZATION_FAILED; > > +#ifdef HAVE_DRI3_MODIFIERS > xcb_randr_lease_t lease = xcb_generate_id(connection); > xcb_randr_create_lease_cookie_t cl_c = > xcb_randr_create_lease(connection, root, lease, 1, 1, > @@ -2324,6 +2325,7 @@ wsi_acquire_xlib_display(VkPhysicalDevice > physical_device, > return VK_ERROR_INITIALIZATION_FAILED; > > wsi->fd = fd; > +#endif > > return VK_SUCCESS; > } > -- > 2.11.0 > > _______________________________________________ > mesa-dev mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
