https://bugs.freedesktop.org/show_bug.cgi?id=92552
--- Comment #12 from asimiklit <[email protected]> ---
(In reply to Ian Romanick from comment #9)
> Comment on attachment 119006 [details] [review]
> egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS
>
> Review of attachment 119006 [details] [review]:
> -----------------------------------------------------------------
>
> There are a few things wrong with this patch. First, you can't check the
> version when you see EGL_CONTEXT_FLAGS in the attribs list because the
> application could specify the requested version after flags. This should
> not generate an error:
>
> EGL_CONTEXT_FLAGS, EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR,
> EGL_CONTEXT_CLIENT_VERSION, 3,
> 0
>
> Second, it is not correct to generate EGL_BAD_MATCH for
> EGL_CONTEXT_OPENGL_ROBUST_ACCESS_BIT_KHR when
> EGL_EXT_create_context_robustness is not supported. Think of it this way...
> if we deleted all support and knowledge of
> EGL_EXT_create_context_robustness, what error would be generated? Default
> case in the switch statement says EGL_BAD_ATTRIBUTE.
I suggest to improve this test in the following way:
https://patchwork.freedesktop.org/patch/256081/
(In reply to Vinson Lee from comment #11)
> mesa: 1e8435ce0cce671024ebf9c5465ea8bdcb563b69 (master 11.3.0-devel)
> This regression is still present.
The possible mesa fix was suggested:
https://patchwork.freedesktop.org/patch/256063/
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
