On Friday, October 19, 2018 3:04:45 PM PDT Marek Olšák wrote: > On Mon, Oct 15, 2018 at 6:35 PM Kenneth Graunke <kenn...@whitecape.org> > wrote: > > > From: Jason Ekstrand <jason.ekstr...@intel.com> > > > > They're not required to be the same as the access flag on the image > > unit. For hardware that does shader image lowering based on the > > qualifier (Intel), it may be required for state setup. > > --- > > src/gallium/include/pipe/p_state.h | 1 + > > src/mesa/state_tracker/st_atom_image.c | 27 ++++++++++++++++++++++---- > > src/mesa/state_tracker/st_cb_texture.c | 2 +- > > src/mesa/state_tracker/st_texture.c | 2 +- > > src/mesa/state_tracker/st_texture.h | 5 +++-- > > 5 files changed, 29 insertions(+), 8 deletions(-) > > > > diff --git a/src/gallium/include/pipe/p_state.h > > b/src/gallium/include/pipe/p_state.h > > index a58d91fb3dd..331417b1d7f 100644 > > --- a/src/gallium/include/pipe/p_state.h > > +++ b/src/gallium/include/pipe/p_state.h > > @@ -485,6 +485,7 @@ struct pipe_image_view > > struct pipe_resource *resource; /**< resource into which this is a > > view */ > > enum pipe_format format; /**< typed PIPE_FORMAT_x */ > > unsigned access; /**< PIPE_IMAGE_ACCESS_x */ > > + unsigned shader_access; /**< PIPE_IMAGE_ACCESS_x */ > > > > Can you use uint16_t for both access masks? Other than that: > > Reviewed-by: Marek Olšák <marek.ol...@amd.com> > > Marek
Good call, that way we don't make the struct any larger. I made that changed and pushed the patch. Thanks for the review!
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
