Feel free to remove it from src/intel/tools/aubinator_viewer_decoder.cpp
too.
Reviewed-by: Lionel Landwerlin <[email protected]>
Thanks,
-
Lionel
On 28/10/2018 17:09, Eric Engestrom wrote:
This function was there when the file was introduced in commit
38f10d5a03542c60a589 "intel: tools: add aubinator viewer", but was
never actually used.
Cc: Lionel Landwerlin <[email protected]>
Signed-off-by: Eric Engestrom <[email protected]>
---
Lionel, was this function no longer needed in the final revision of this
commit, or did you mean to use it somewhere?
---
src/intel/common/gen_batch_decoder.c | 21 ---------------------
1 file changed, 21 deletions(-)
diff --git a/src/intel/common/gen_batch_decoder.c
b/src/intel/common/gen_batch_decoder.c
index 0a36b1678b504f24d9bf..63f0462757208d513ba9 100644
--- a/src/intel/common/gen_batch_decoder.c
+++ b/src/intel/common/gen_batch_decoder.c
@@ -792,27 +792,6 @@ struct custom_decoder {
{ "MI_LOAD_REGISTER_IMM", decode_load_register_imm }
};
-static inline uint64_t
-get_address(struct gen_spec *spec, const uint32_t *p)
-{
- /* Addresses are always guaranteed to be page-aligned and sometimes
- * hardware packets have extra stuff stuffed in the bottom 12 bits.
- */
- uint64_t addr = p[0] & ~0xfffu;
-
- if (gen_spec_get_gen(spec) >= gen_make_gen(8,0)) {
- /* On Broadwell and above, we have 48-bit addresses which consume two
- * dwords. Some packets require that these get stored in a "canonical
- * form" which means that bit 47 is sign-extended through the upper
- * bits. In order to correctly handle those aub dumps, we need to mask
- * off the top 16 bits.
- */
- addr |= ((uint64_t)p[1] & 0xffff) << 32;
- }
-
- return addr;
-}
-
void
gen_print_batch(struct gen_batch_decode_ctx *ctx,
const uint32_t *batch, uint32_t batch_size,
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
