On Fri, Nov 9, 2018 at 10:51 AM Erik Faye-Lund <erik.faye-l...@collabora.com> wrote: > > On Fri, 2018-11-09 at 10:44 -0500, Ilia Mirkin wrote: > > Errr ... why are these being added to the ABI now? Extensions are > > generally not added in. Some are grandfathered in, but this one would > > be new. > > > > Or is this due to the fact that it's grandfathered in for GL, and > > making that and GLES different would be tricky? > > I'm not sure, really. This feature missed the 18.3 release anyway, so > we have time to fix this up, if anyone knows for sure. > > I don't think there's a good reason to cement this in the GLES ABI, so > I think we should remove it, if that's possible. I don't really know > what makes this appear in the ABI, though. If someone can explain, I'd > be happy to fix things up. > > Anyway, I pushed the test-fixes for now; the ABI change seems to > already have happened.
That cements it as an OK thing to do. When you push a buggy change, the solution isn't "make the test ignore the bug". The solution is to either fix the bug or revert the offending change. _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
