Eric Engestrom <eric.engest...@intel.com> writes:
> On Thursday, 2018-11-15 15:05:27 -0800, Eric Anholt wrote:
>> diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c
>> index f32c0cd9885f..8f035b7c7d84 100644
>> --- a/src/gbm/backends/dri/gbm_dri.c
>> +++ b/src/gbm/backends/dri/gbm_dri.c
>> @@ -301,31 +301,21 @@ dri_bind_extensions(struct gbm_dri_device *dri,
>> return ret;
>> }
>>
>> +static void
>> +gbm_loader_log(int level, const char *fmt, ...)
>> +{
>> + if (level > _LOADER_WARNING)
>> + return;
>> +
>> + va_list ap;
>> + va_start(ap, fmt);
>> + vfprintf(stderr, fmt, ap);
>> + va_end(ap);
>> +}
>
> Why? This is the exact behaviour of the default_logger() :)
>
> If you still want to add it, I'd do it in a separate commit, since it
> has nothing to do with the rest of this patch.
>
> With gbm_loader_log() split out, this is:
> Reviewed-by: Eric Engestrom <eric.engest...@intel.com>Thanks. I wrote this when confused by my dlopen() information not printing in the gbm case (because the useful debug is at a lower level and can't be upgraded in severity because we expect some dlopen()s to fail in the normal case). I ended up cutting out the level check while debugging, and never went back and confirmed that it was useful with the check in at all!
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
