Here's v3 of the series. I've updated to account for most of the comments, except I went back and forth and then ultimately back again on Roladnd suggestion. It may be more intuitive to always have surf->nr_samples be the number of samples but that means we'll have to go update all state trackers to set it in the template and modify all drivers to copy it in the constructor. At the same time, having surf->nr_samples be 0 if it wasn't attached with FramebufferTexture2DMultisampleEXT also seems like perfectly fine semantics, and doesn't require updating state trackers or drivers that don't care or support this feature.
Kristian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev