On Fri, Jan 4, 2019 at 5:04 PM Ilia Mirkin <[email protected]> wrote: > > On Fri, Jan 4, 2019 at 4:56 PM Kevin Strasser <[email protected]> > wrote: > > diff --git a/src/mesa/drivers/dri/common/utils.c > > b/src/mesa/drivers/dri/common/utils.c > > index b52c59f..1cf9362 100644 > > --- a/src/mesa/drivers/dri/common/utils.c > > +++ b/src/mesa/drivers/dri/common/utils.c > > @@ -200,6 +200,10 @@ driCreateConfigs(mesa_format format, > > { 0x000003FF, 0x000FFC00, 0x3FF00000, 0x00000000 }, > > /* MESA_FORMAT_R10G10B10A2_UNORM */ > > { 0x000003FF, 0x000FFC00, 0x3FF00000, 0xC0000000 }, > > + /* MESA_FORMAT_RGBX_FLOAT16 */ > > + { 0x000000000000ffff, 0x00000000ffff0000, 0x0000ffff00000000, > > 0x0000000000000000}, > > + /* MESA_FORMAT_RGBA_FLOAT16 */ > > + { 0x000000000000ffff, 0x00000000ffff0000, 0x0000ffff00000000, > > 0xffff000000000000}, > > I'm about 37% sure that these need to have a ULL suffix on them, as > otherwise immediates aren't upgraded to a wider type. I'm surprised > there were no warnings/errors about that. Perhaps I'm just wrong > though -- good to check either way. > > If if turns out I'm right, there were a few other instances of such > wide immediates.
As confirmed on IRC, appears that I'm wrong about this. The values do get upgraded to the wider type. -ilia _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
