On 2019-01-18 — 16:04, Francisco Jerez wrote:
[snip]
> > diff --git a/src/gallium/state_trackers/clover/core/module.hpp
> > b/src/gallium/state_trackers/clover/core/module.hpp
> > index 2ddd26426fb..ff7e9b6234a 100644
> > --- a/src/gallium/state_trackers/clover/core/module.hpp
> > +++ b/src/gallium/state_trackers/clover/core/module.hpp
> > @@ -41,14 +41,19 @@ namespace clover {
> > data_local,
> > data_private
> > };
> > + enum class flags_t {
>
> You probably want the type to be "enum flags" for consistency with the
> other enums defined here.For consistency, that would be better indeed. Would it make sense to convert the other enums to scoped enums? The advantages would be the scoping and the better type checking, but that’s about it. > > + none, > > + allow_link_options > > And explicitly define allow_link_options = 1u, assuming that this is > going to be a bit-mask with multiple flags. I’ll need to have another look at which other flags could go here, but you’re right, we probably want to support multiple flags being set. > Is this patch being used at all in this series? Not in this one, but it will be in the next merge request which adds support for SPIR-V as a second main IR in clover alongside LLVM IR. I’ll drop this patch from this series and add it to the next one, with the modifications you discussed. Pierre
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
