Am Donnerstag, den 24.01.2019, 07:31 +0100 schrieb Christian Gmeiner: > Hi Lucas > > Am Mo., 21. Jan. 2019 um 10:03 Uhr schrieb Lucas Stach > <[email protected]>: > > > > Hi Christian, > > > > first of all, thanks for figuring this out. This is really nice > > to finally know how it works. > > > > Am Montag, den 21.01.2019, 07:49 +0100 schrieb Christian Gmeiner: > > > Defines how sampler (and pixel pipes) needs to access the data > > > represented with a resource. The used default is mode is > > > ETNA_ADDRESSING_MODE_TILED. > > > > Do you see any reason why we need a separate property for this? IMHO > > etna_resource is already a bit too fat and from this set of patches I > > can't see why we can't infer the addressing mode from the layout. Do > > you have something specific in mind, that I don't see right now? > > > > We are using ETNA_LAYOUT_LINEAR for compressed textures with an > addressing mode of TILED (register value of 0). That is the root cause why > was forced to add something new to etna_resource as I can not trust that > ETNA_LAYOUT_LINEAR for sampler resources implies an linear addressing > mode.
Ah, right. This had escaped my mind. With this out of the way, patch looks good. Regards, Lucas _______________________________________________ mesa-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-dev
