LGTM. Reviewed-by: Brian Paul <[email protected]>
I'll push this tomorrow, or after Ilia reviews too.
On 01/29/2019 12:21 PM, Neha Bhende wrote:
> We need to initialize all fields in rs->prim explicitly while
> creating new rastpos stage.
>
> Fixes: bac8534267 ("st/mesa: allow glDrawElements to work with GL_SELECT
> feedback")
>
> v2: Initializing all fields in rs->prim as per Ilia.
>
> Reviewed-by: Brian Paul <[email protected]>
> ---
> src/mesa/state_tracker/st_cb_rasterpos.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/state_tracker/st_cb_rasterpos.c
> b/src/mesa/state_tracker/st_cb_rasterpos.c
> index fecaaf7..c54b50d 100644
> --- a/src/mesa/state_tracker/st_cb_rasterpos.c
> +++ b/src/mesa/state_tracker/st_cb_rasterpos.c
> @@ -208,6 +208,10 @@ new_draw_rastpos_stage(struct gl_context *ctx, struct
> draw_context *draw)
> rs->prim.end = 1;
> rs->prim.start = 0;
> rs->prim.count = 1;
> + rs->prim.pad = 0;
> + rs->prim.num_instances = 1;
> + rs->prim.base_instance = 0;
> + rs->prim.is_indirect = 0;
>
> return rs;
> }
>
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
