Emil Velikov wrote:
> On Mon, 28 Jan 2019 at 18:42, Kevin Strasser <kevin.stras...@intel.com> wrote:
> > diff --git a/src/mesa/drivers/dri/common/utils.c
> > b/src/mesa/drivers/dri/common/utils.c
> > index 5a66bcf..1fdc160 100644
> > --- a/src/mesa/drivers/dri/common/utils.c
> > +++ b/src/mesa/drivers/dri/common/utils.c
> > @@ -200,9 +200,33 @@ driCreateConfigs(mesa_format format,
> > { 0x000003FF, 0x000FFC00, 0x3FF00000, 0x00000000 },
> > /* MESA_FORMAT_R10G10B10A2_UNORM */
> > { 0x000003FF, 0x000FFC00, 0x3FF00000, 0xC0000000 },
> > + /* For anything wider than 32 bpp */
> > + { 0, 0, 0, 0 },
> > + };
> > +
> Unused entry?
Maybe this hunk belongs in 08/ where the entry gets used...
> > diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c
> > index 492f01d..d6391a3 100644
> > --- a/src/mesa/main/context.c
> > +++ b/src/mesa/main/context.c
> > @@ -1537,9 +1537,9 @@ check_compatible(const struct gl_context *ctx,
> > ctxvis->foo != bufvis->foo) \
> > return GL_FALSE
> >
> > - check_component(redMask);
> > - check_component(greenMask);
> > - check_component(blueMask);
> I think these were meant to say.
I didn't see any reason to check both mask and shift values. Can you explain
why
they would still be needed?
Thanks,
Kevin
> With the check_component() reinstated (or clarified why they're gone),
> the patch is
> Reviewed-by: Emil Velikov <emil.veli...@collabora.com>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
