On Saturday, 2019-02-02 10:32:15 -0500, Marek Olšák wrote:
> On Sat, Feb 2, 2019, 7:17 AM Eric Engestrom <eric.engest...@intel.com wrote:
>
> > On Friday, 2019-02-01 15:42:17 -0500, Marek Olšák wrote:
> > > If there is no feedback soon, I'll push this.
> >
> > Have you tested that xcb-randr < 1.12 works?
> > Probably shouldn't remove a restriction unless you're sure it isn't
> > needed :)
> >
>
> Is this a joke? I'm just mirroring autotools. Supporting the same linux
> distributions as autotools is a requirement for meson's general acceptance.
No, I'm being serious: just because a restriction didn't exist on
autotools doesn't mean that code path was exercised by people running
an old xcb-randr, hence the need to test it :)
I didn't mean to offend you, I was just asking the question to make sure
this was tested before we claim to support xcb-randr < 1.12, as it might
be that autotools was simply missing the version check.
>
> Marek
>
>
> > >
> > > Marek
> > >
> > > On Wed, Jan 30, 2019 at 12:44 PM Erik Faye-Lund <
> > > erik.faye-l...@collabora.com> wrote:
> > >
> > > > On Wed, 2019-01-30 at 12:32 -0500, Marek Olšák wrote:
> > > > > ping
> > > > >
> > > >
> > > > Probably worth including Keith, who added this line...
> >
> > Added him.
> >
> > > >
> > > > But yeah, I tend to think that this makes sense. The autotools-build
> > > > doesn't seem to tie this to a specific version, and seems to have been
> > > > used without problems for almost a year. But let's hear what Keith
> > > > things first...
> > > >
> > > > > On Fri, Jan 25, 2019 at 5:48 PM Marek Olšák <mar...@gmail.com>
> > wrote:
> > > > > > From: Marek Olšák <marek.ol...@amd.com>
> > > > > >
> > > > > > autotools doesn't have any requirement. This fixes meson on Ubuntu
> > > > > > 16.04.
> > > > > > ---
> > > > > > meson.build | 2 +-
> > > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/meson.build b/meson.build
> > > > > > index 34e2a032548..7f16c3070fe 100644
> > > > > > --- a/meson.build
> > > > > > +++ b/meson.build
> > > > > > @@ -1389,21 +1389,21 @@ if with_platform_x11
> > > > > > dep_xxf86vm = dependency('xxf86vm')
> > > > > > endif
> > > > > > dep_glproto = dependency('glproto', version : '>= 1.4.14')
> > > > > > endif
> > > > > > if (with_egl or (
> > > > > > with_gallium_vdpau or with_gallium_xvmc or with_gallium_xa
> > > > > > or
> > > > > > with_gallium_omx != 'disabled'))
> > > > > > dep_xcb_xfixes = dependency('xcb-xfixes')
> > > > > > endif
> > > > > > if with_xlib_lease
> > > > > > - dep_xcb_xrandr = dependency('xcb-randr', version : '>= 1.12')
> > > > > > + dep_xcb_xrandr = dependency('xcb-randr')
> > > > > > dep_xlib_xrandr = dependency('xrandr', version : '>= 1.3')
> > > > > > endif
> > > > > > endif
> > > > > >
> > > > > > if get_option('gallium-extra-hud')
> > > > > > pre_args += '-DHAVE_GALLIUM_EXTRA_HUD=1'
> > > > > > endif
> > > > > >
> > > > > > _sensors = get_option('lmsensors')
> > > > > > if _sensors != 'false'
> > > > > > _______________________________________________
> > > > > > mesa-dev mailing list
> > > > > > mesa-dev@lists.freedesktop.org
> > > > > > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > > >
> > > >
> >
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
