hmm, nothing to disabled them again? Reviewed-by: Bas Nieuwenhuizen <b...@basnieuwenhuizen.nl>
On Tue, Mar 5, 2019 at 6:06 PM Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: > > The mask should be accumulated if two calls are used for > binding two buffers at different indexes. Otherwise, the > driver only accounts for the last one. > > Noticed while glancing at this code. > > Cc: 18.3 19.0 <mesa-sta...@lists.freedesktop.org> > Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> > --- > src/amd/vulkan/radv_cmd_buffer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/amd/vulkan/radv_cmd_buffer.c > b/src/amd/vulkan/radv_cmd_buffer.c > index 5b66930d137..b8d8583c1b0 100644 > --- a/src/amd/vulkan/radv_cmd_buffer.c > +++ b/src/amd/vulkan/radv_cmd_buffer.c > @@ -4987,7 +4987,7 @@ void radv_CmdBindTransformFeedbackBuffersEXT( > enabled_mask |= 1 << idx; > } > > - cmd_buffer->state.streamout.enabled_mask = enabled_mask; > + cmd_buffer->state.streamout.enabled_mask |= enabled_mask; > > cmd_buffer->state.dirty |= RADV_CMD_DIRTY_STREAMOUT_BUFFER; > } > -- > 2.21.0 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev
