On 25.04.19 04:45, Marek Olšák wrote:
[snip]
    -       bool                            clear_db_cache_before_clear;
             bool                            has_msaa_sample_loc_bug;
             bool                            has_ls_vgpr_init_bug;
             bool                            has_dcc_constant_encode;
             bool                            dpbb_allowed;
             bool                            dfsm_allowed;
             bool                            llvm_has_working_vgpr_indexing;

    +       struct {
    +#define OPT_BOOL(name, dflt, description) uint8_t name:1;


Why not bool instead of uint8_t?

Sure.


    +#include "si_debug_options.inc"


Why not use the .h file extension?

The original intention was to distinguish it from header files where including is supposed idempotent, i.e. including the file a second time makes no difference. Anyway, I'm changing it.

Cheers,
Nicolai



Other than those, this is:

Reviewed-by: Marek Olšák <[email protected] <mailto:[email protected]>>

Marek


--
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.
_______________________________________________
mesa-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to