On 05/30/2012 03:19 PM, Eric Anholt wrote:
On Tue, 29 May 2012 15:51:47 -0700, "Ian Romanick"<i...@freedesktop.org> wrote:+TEST(GetProcAddress, ABINameByOffset) +{ + /* 408 functions have had their locations in the dispatch table set since + * the danw of time. Verify that all of these functions are at the correct^dawn
D'oh!
(also copy and pasted) I don't like the "as big as at some git sha1" test given that you immediately go on to show that the test is invalid and just hack around it. That sounds to me like "this test should be removed". Maybe just check that it's bigger than the fixed ABI?
The intention is for the test to catch changes that accidentally cause the dispatch table to shrink. The dispatch table pretty much only ever grows. The most recent change to gl_API.xml that caused the dispatch table to shrink was a5f220607 in 2006. I'd be surprised if there were more changes after this series that shrink the dispatch table before another 6 years. :)
Anything else that causes a shrink is a bug. I want to have some kind of test for that, but it doesn't necessarily have to be this test.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
