On 06/05/2012 03:35 PM, Brian Paul wrote: > The functions for handling 1D, 2D and 3D texture images were nearly > identical. This folds them all together. > --- > src/mesa/drivers/common/driverfuncs.c | 4 +- > src/mesa/drivers/dri/intel/intel_tex_image.c | 60 ++---------------- > src/mesa/drivers/dri/nouveau/nouveau_texture.c | 43 +++----------- > src/mesa/drivers/dri/radeon/radeon_texture.c | 41 ++---------- > src/mesa/main/dd.h | 44 +++---------- > src/mesa/main/teximage.c | 36 ++--------- > src/mesa/main/texobj.c | 28 +------- > src/mesa/main/texstore.c | 78 > ++++-------------------- > src/mesa/main/texstore.h | 31 ++------- > src/mesa/state_tracker/st_cb_texture.c | 51 +++------------- > 10 files changed, 73 insertions(+), 343 deletions(-)
Looks great. I haven't tested it, but I read through all of them carefully. Nice attention to detail making sure 1 got passed in instead of 0 (so it doesn't return doing nothing), and adding the dims != 2, dims == 3 checks in driver specific upload code. For the series: Reviewed-by: Kenneth Graunke <[email protected]> _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
