Chad Versace <chad.vers...@linux.intel.com> writes: > This function felt sloppy, so this patch cleans it up a little bit. > > - Rename `color` to `i`. It is not a color value, only an iterator int.
I'm meh on this change.
> - Move `depth_bits[0] = 0` into the non-accum loop because that is where
> it used. The accum loop later overwrites depth_bits[0].
This makes sense -- move it next to the place that sets up the rest of
the array.
> - Redefine `msaa_samples_array` as static const because it is never
> modified.
Maybe instead, singlesample_samples[] = {0} and multisample_samples[] =
{4, 8}? The array math in the next patch was not pretty.
Feel free to ignore me on this patch.
pgpADZdxeG4Fj.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
