On Tuesday 06 November 2012, Ian Romanick wrote: > On 11/05/2012 09:57 AM, Fredrik Höglund wrote: > > This extension is functionally the same as GL_MESA_pack_invert, > > but is also available in GLES. > > Do we have any piglit tests for this?
Not yet. > If we're going to have the two pieces of state alias each other, we > should submit patches to both extension specs saying such. In > MESA_pack_invert, add something like: > > Dependencies on ANGLE_pack_reverse_row_order: > > If both ANGLE_pack_reverse_row_order and MESA_pack_invert are > supported by the implementation, the same state flag is used > for both PACK_REVERSE_ROW_ORDER_ANGLE and PACK_INVERT_MESA. > Calling Enable (or Disable) on either enum will cause > IsEnabled to return true (or false) for the other. > > I would suggest sending the ANGLE_pack_reverse_row_order change to > Daniel Koch (listed in the extension spec). Yeah, that's a good point. I'll take care of it. > > @@ -142,7 +144,6 @@ _mesa_PixelStorei( GLenum pname, GLint param ) > > FLUSH_VERTICES(ctx, _NEW_PACKUNPACK); > > ctx->Pack.Invert = param; > > break; > > - > > Spurious whitespace change. The only place in the switch statement where there was a blank line between cases. Fredrik _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
