On Sat, Nov 17, 2012 at 10:17 PM, Kenneth Graunke <kenn...@whitecape.org> wrote: > On 11/17/2012 09:13 PM, Matt Turner wrote: >> >> On Sat, Nov 17, 2012 at 8:55 PM, Kenneth Graunke <kenn...@whitecape.org> >> wrote: >>> >>> Apparently this was accidentally marked as unimplemented, and thus not >>> put in the dispatch table. >>> >>> Fixes es3conform's copy_buffer_parameters, copy_buffer_data, >>> and copy_buffer_usage tests. >>> >>> Cc: Paul Berry <stereotype...@gmail.com> >>> --- >> >> >> The reason it wasn't in the dispatch table was because it was never >> tested. Do the tests actually /test/ this function, or just make use >> of it? It'd be nice if we were really sure the function was >> implemented properly. > > > Yes, it actually tests the function. copy_buffer_defaults verifies that > GetBufferParameteri64v returns proper values for > BUFFER_SIZE, BUFFER_USAGE, BUFFER_ACCESS_FLAGS, BUFFER_MAPPED, > BUFFER_MAP_OFFSET, and BUFFER_MAP_LENGTH. Which is every case. > > So I feel confident in enabling it. > > I also should mention that this additionally fixes es3conform's > pixel_buffer_object_bind, pixel_buffer_object_parameteriv, > pixel_buffer_object_texture_read, and pixel_buffer_object_usage tests.
Tested-by: Matt Turner <matts...@gmail.com> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
