On 12/23/2012 11:43 PM, Eric Anholt wrote:
Improves GLBenchmark 2.1 offscreen performance by 3.2% +/- 1.5% (n=52). --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 3 +++ src/mesa/drivers/dri/intel/intel_tex.c | 4 ++++ src/mesa/drivers/dri/intel/intel_tex_image.c | 1 + src/mesa/drivers/dri/intel/intel_tex_obj.h | 6 ++++++ src/mesa/drivers/dri/intel/intel_tex_validate.c | 18 ++++++++++++++++-- 5 files changed, 30 insertions(+), 2 deletions(-)
This looks good to me, but I'm not sure I'm qualified to give it a proper review, which I think would be to
1. look for any cases where the validation/pull-in-foreign-image code is necessary but not covered by needs_validate = true
2. make sure needs_validate = true cases are indeed necessary But, FWIW, I'll give it a: Reviewed-by: Kenneth Graunke <[email protected]> _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
