Paul Berry <stereotype...@gmail.com> writes: > On 19 January 2013 11:06, Kenneth Graunke <kenn...@whitecape.org> wrote: >> + //intel_renderbuffer_set_needs_downsample(dst_irb); >> > > I'm ok leaving this out--at the moment there's no way this code can be hit > for a multisampled destination image. However, if we ever get around to > implementing the GLES extension EXT_multisampled_render_to_texture, we'll > have to have a hard think about what the correct behaviour should be. > Perhaps we should put a comment here saying something like: > > /* Note: there is no need to call intel_renderbuffer_set_needs_downsample() > on the destination buffer, since automatic downsample is only needed for > multisampled window system framebuffers, which are not allowed as > destinations for CopyTexSubImage. However, this will need to be revisited > if we ever support EXT_multisampled_render_to_texture. */
Isn't that extension all about multisampled user framebuffers, not window system framebuffers?
pgpVJx6zCIoQN.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
