Ian Romanick <i...@freedesktop.org> writes: > +bool > +link_uniform_blocks_are_compatible(const gl_uniform_block *a, > + const gl_uniform_block *b) > +{ > + assert(strcmp(a->Name, b->Name) == 0); ... > + if (strcmp(old_block->Name, new_block->Name) == 0) > + return link_uniform_blocks_are_compatible(old_block, new_block) > + ? i : -1;
Moving the strcmp to the body of the function, (it's there already---just need to replace the assert with "if(strcmp(a,b)) return false;"), would give a less fragile interface here. With that: Reviewed-by: Carl Worth <cwo...@cworth.org> -Carl -- carl.d.wo...@intel.com
pgpRp5E0Kx5GY.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev