On 03/29/2013 10:40 AM, Eric Anholt wrote:
Alessandro Pignotti noted when I added this code in commit 0e723b135bfd59868c92c3ae243f1adaedaec3a5 that it's in the else block for "if (busy)", so this debug print couldn't happen. --- src/mesa/drivers/dri/intel/intel_buffer_objects.c | 5 ----- 1 file changed, 5 deletions(-)diff --git a/src/mesa/drivers/dri/intel/intel_buffer_objects.c b/src/mesa/drivers/dri/intel/intel_buffer_objects.c index ac265db..e270db8 100644 --- a/src/mesa/drivers/dri/intel/intel_buffer_objects.c +++ b/src/mesa/drivers/dri/intel/intel_buffer_objects.c @@ -227,11 +227,6 @@ intel_bufferobj_subdata(struct gl_context * ctx, drm_intel_bo_unreference(temp_bo); } } else { - if (unlikely(intel->perf_debug)) { - if (drm_intel_bo_busy(intel_obj->buffer)) { - perf_debug("Stalling on the GPU in glBufferSubData().\n"); - } - } drm_intel_bo_subdata(intel_obj->buffer, offset, size, data); } }
Yep, that should never happen. Reviewed-by: Kenneth Graunke <[email protected]> _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
