Ian Romanick <i...@freedesktop.org> writes: > On 04/16/2013 05:21 PM, Eric Anholt wrote: >> This should already be handled by _mesa_base_tex_format() calls in >> TexImage*. >> --- >> >> NOTE! >> >> I've replaced the actual patch full of unindentation of code described by: >> src/mesa/main/texformat.c | 1184 >> ++++++++++++++++++++------------------------- >> 1 file changed, 533 insertions(+), 651 deletions(-) >> >> with the git show -b output so that someone can actually review it. >> If you want to apply the series, please just use the "formats" branch >> of my tree. > > Now it's your turn to get, "I've got a branch for that!" I had started > working on some of this earlier this year, but I wandered off when Marek > was doing some renaming. You can check the choose-format2 branch of my > tree. I haven't rebased it since February, so, yeah. > > I was working towards simplifying this code and making it testable by > unit tests. I wanted to verify that if a driver exposes some extension > or core version that it also supports the necessary MESA_FORMATs.
Actually, I can't. I don't see such a branch in your tree. And I'm interested in just getting this pushed, which should fix: https://bugs.freedesktop.org/show_bug.cgi?id=53562 Also, I expect that unit tests wouldn't have caught that bug, and that the right solution is actual piglit rendering tests for ES1.
pgpPX2nQsspRg.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
