Marek Olšák <[email protected]> writes:

> 1) The tabs are used in the entire file. They might have got there
> while I was moving some of the bits of code around. I don't really use
> tabs for core Mesa work. I can change the tabs to spaces unless you
> mean I should change everything to tabs (you didn't make that clear).

Official mesa style is all spaces -- Ian and I were violating that for
years, and so to get things consistent eventually, I mention when +
lines have tabs.

> 2) _mesa_get_sampler_uniform_value is really called at link time,
> specifically at the conversion to TGSI. The only case where it might
> be called after link time is when a new shader variant is being
> generated, though i'm not really sure about this. Anyway, the function
> already calls linker_error above my code to report an error. I decided
> to do the same. _mesa_problem sounds better though.

OK, either way.

Attachment: pgpoN_d1iTQkL.pgp
Description: PGP signature

_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to