Patches 7-9 need to be reworked a little bit.

First, the "dri" and "egl/dri2" commit have intermingled changes to the
intel driver. The changes to the intel driver should be pulled out into a
separate final commit.

Second, the commit subjects are imprecise and difficult to understand. If I
were to be reading the git log, I would have a difficult time guessing what
the patches did and did not do. Simplifying the subjects to something
succinct and clear like this should be good:

dri: Extend DRI_IMAGE for EGL_EXT_image_dma_buf_import

    Bump DRI_IMAGE version to 8. Add enums and entry point for the
    extension.

egl/main: Implement EGL_EXT_image_dma_buf_import
egl/dri2: Implement EGL_EXT_image_dma_buf_import
intel: Implement EGL_EXT_image_dma_buf_import

Also, depending on the outcome of the other ongoing discussion,
the intel commit may need to do some extra validation of
formats.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to