On 08/22/2013 06:19 PM, Paul Berry wrote:
On 21 August 2013 23:26, Kenneth Graunke <[email protected] <mailto:[email protected]>> wrote:We're soon going to be calling brw_alloc_reg_set() from outside of the visitor, where we don't have the precomputed "max_grf" variable handy. Signed-off-by: Kenneth Graunke <[email protected] <mailto:[email protected]>> Cc: Paul Berry <[email protected] <mailto:[email protected]>> Thanks for doing this, Ken! Series is: Reviewed-by: Paul Berry <[email protected] <mailto:[email protected]>> Possible follow-up idea: maybe we should move max_grf out of fs_visitor and vec4_visitor, and instead put it into brw and initialize it in brwCreateContext(), like we do for brw->max_wm_threads etc.
Yeah...we could. But really, we should just get rid of the ridiculous hack range and go back to using BRW_MAX_GRF everywhere.
--Ken _______________________________________________ mesa-dev mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/mesa-dev
