David Heidelberger <david.heidelber...@ixit.cz> writes: > From e004b63b2896ac2c8951cfda49d4a54d72b16449 Mon Sep 17 00:00:00 2001 > From: David Heidelberger <david.heidelber...@ixit.cz> > Date: Wed, 23 Oct 2013 23:35:42 +0200 > Subject: [PATCH] clover: mark gcc 4.7.0 as broken > > --- > configure.ac | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index dc15ad4..ea6f2f3 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -109,6 +109,7 @@ if test "x$GCC" = xyes -a "x$acv_mesa_CLANG" = xno; > then > if test $? -eq 0; then > GCC_VERSION_MAJOR=`echo $GCC_VERSION | cut -d. -f1` > GCC_VERSION_MINOR=`echo $GCC_VERSION | cut -d. -f2` > + GCC_VERSION_MAINTENANCE=`echo $GCC_VERSION | cut -d. -f3` > fi > > if test $GCC_VERSION_MAJOR -lt 3 -o $GCC_VERSION_MAJOR -eq 3 -a > $GCC_VERSION_MINOR -lt 3 ; then > @@ -1371,8 +1372,9 @@ if test "x$enable_opencl" = xyes; then > AC_MSG_ERROR([cannot enable OpenCL without Gallium]) > fi > > - if test $GCC_VERSION_MAJOR -lt 4 -o $GCC_VERSION_MAJOR -eq 4 -a > $GCC_VERSION_MINOR -lt 7; then > - AC_MSG_ERROR([gcc >= 4.7 is required to build clover]) > + if test $GCC_VERSION_MAJOR -lt 4 -o \ > + $GCC_VERSION_MAJOR -eq 4 -a $GCC_VERSION_MINOR -lt 7 -a > $GCC_VERSION_MAINTENANCE -lt 1; then > + AC_MSG_ERROR([gcc >= 4.7.1 is required to build clover]) > fi
I don't think this is doing what you intended, it's going to accept e.g. gcc-4.6.1 again. And I don't think 4.7.1 is going to be good enough, it seems like the feature we rely on was fixed in 4.7.3. Thank you. > > if test "x$have_libclc" = xno; then > -- > 1.8.4 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
pgp0kZScm9Ibv.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
