On Thu, Nov 7, 2013 at 1:22 PM, Dave Airlie <airl...@gmail.com> wrote:
> On Sat, Oct 12, 2013 at 8:10 AM, Ian Romanick <i...@freedesktop.org> wrote: > > From: Ian Romanick <ian.d.roman...@intel.com> > > > > The enumerated values are currently allocated from Intel's range. > > Some highlevel comments below, > > > > + GLX renderer attribute number description > > + of values > > + ---------------------- --------- ----------- > > + GLX_RENDERER_VENDOR_ID_MESA 1 PCI ID of the device > vendor > > + GLX_RENDERER_DEVICE_ID_MESA 1 PCI ID of the device > > Okay PCI IDs might seem useful but we have a lot of situations where > they aren't available, > I was thinking the same, but then noticed that it's an int, and a pci device or vendor id is 16 bit, so you could implement this by returning the pciid if you have it, or something > 0xFFFF if you don't have it (and sort of make sure that those don't overlap). Stéphane > a) ARM devices generally don't have them > b) nvidia generally espouse using PCI IDs in favour of a chip family > ID they bake into the GPUs, > nouveau doesn't even know the actual PCI IDs in userspace, we could > find them but it does take a bit more work, like new kernel interface. > > > + > > + GLX renderer attribute description > > + ---------------------- ----------- > > + GLX_RENDERER_VENDOR_ID_MESA Name of the renderer provider. This > may > > + differ from the vendor name of the > > + underlying hardware. > > + GLX_RENDERER_DEVICE_ID_MESA Name of the renderer. This may > differ from > > + the name of the underlying hardware > (e.g., > > + for a software renderer). > > + > > + If <attribute> is not a recognized value, NULL is returned, but no > GLX > > + error is generated. > > + > > + The string returned for GLX_RENDERER_VENDOR_ID_MESA will have the > same > > + format as the string that would be returned by glGetString of > GL_VENDOR. > > + It may, however, have a different value. > > Any reason for the value to be different here? Like a use case? > > + 14) Why not make the queries from issue #14 GL functions (instead > of GLX)? > > + > > from issue 14? this is issue 14 > > Dave. > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev