On Sunday, July 13, 2014 01:52:00 PM Chris Forbes wrote: > Signed-off-by: Chris Forbes <chr...@ijw.co.nz> > --- > src/glsl/lower_ubo_reference.cpp | 50 ++++++++++++++++++++++++---------------- > 1 file changed, 30 insertions(+), 20 deletions(-) > > diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp > index c49ae34..80edd93 100644 > --- a/src/glsl/lower_ubo_reference.cpp > +++ b/src/glsl/lower_ubo_reference.cpp > @@ -69,9 +69,10 @@ public: > * \c UniformBlocks array. > */ > static const char * > -interface_field_name(void *mem_ctx, char *base_name, ir_dereference *d) > +interface_field_name(void *mem_ctx, char *base_name, ir_dereference *d, ir_rvalue **array_index)
Maybe call this nonconst_block_index or nonconst_array_index or such? It doesn't seem to be set in the constant-indexed case, and the caller uses whether it was set to determine whether there was a non-constant array index. Whatever you think is best. This series looks good to me: Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> However, you might ping Ian - I know he's been working on a bunch of bug fixes in the lower_ubo_reference code. He's also more familiar with this code than I am.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
