Am 22.07.2014 12:02, schrieb Richard Sandiford: > This means that each RnGnBnxn format has a reversed counterpart, > which is necessary for handling big-endian mesa<->gallium mappings. > The associated UNORM and SRGB formats already exist. > > Signed-off-by: Richard Sandiford <rsand...@linux.vnet.ibm.com> > --- > src/gallium/auxiliary/util/u_format.csv | 3 +++ > src/gallium/include/pipe/p_format.h | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_format.csv > b/src/gallium/auxiliary/util/u_format.csv > index d01dd06..5bca5e8 100644 > --- a/src/gallium/auxiliary/util/u_format.csv > +++ b/src/gallium/auxiliary/util/u_format.csv > @@ -387,3 +387,6 @@ PIPE_FORMAT_G8R8_UNORM , plain, 1, 1, un8 , > un8 , , , yx01, rgb > PIPE_FORMAT_G8R8_SNORM , plain, 1, 1, sn8 , sn8 , , , yx01, rgb > PIPE_FORMAT_G16R16_UNORM , plain, 1, 1, un16, un16, , , yx01, rgb > PIPE_FORMAT_G16R16_SNORM , plain, 1, 1, sn16, sn16, , , yx01, rgb > + > +PIPE_FORMAT_A8B8G8R8_SNORM , plain, 1, 1, sn8 , sn8 , sn8 , sn8 , > wzyx, rgb > +PIPE_FORMAT_X8B8G8R8_SNORM , plain, 1, 1, x8, sn8, sn8, sn8, > wzy1, rgb > diff --git a/src/gallium/include/pipe/p_format.h > b/src/gallium/include/pipe/p_format.h > index 1dba5b5..a0cdde3 100644 > --- a/src/gallium/include/pipe/p_format.h > +++ b/src/gallium/include/pipe/p_format.h > @@ -354,6 +354,9 @@ enum pipe_format { > PIPE_FORMAT_G16R16_UNORM = 261, > PIPE_FORMAT_G16R16_SNORM = 262, > > + PIPE_FORMAT_A8B8G8R8_SNORM = 263, > + PIPE_FORMAT_X8B8G8R8_SNORM = 264, > + > PIPE_FORMAT_COUNT > }; > >
This change + 2/7 and 2/5, 3/5 from the other series change core gallium definitions, thus they should be prefixed with gallium, not util, even if there's some util change as well. Other than that I think they look reasonable though I'm not really qualified as I stayed out of the endianness discussions - always gives me headaches thinking about it :-). Roland _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev