Connor Abbott <[email protected]> writes:

> Before, when we encountered a situation where we had to optimistically
> color a node, we would immediately give up and push all the remaining
> nodes on the stack in the order of their index - which is a random, and
> potentially not optimal, order. Instead, choose one node to
> optimistically color in ra_select(), and then once we've optimistically
> colored it, keep on going as normal in the hopes that we've opened up
> more avenues for the normal select phase to make progress. In cases with
> high register pressure, this helps make the order we push things on the
> stack much better, and therefore increase the chance that we can allocate
> successfully.
>
> Also, consider all the spillable registers as canidates for spilling,
> including the ones that were successfully given a color. The old
> behavior was incompatible with the new way of doing optimistic coloring,
> so while we're modifying this code let's make it do something more
> sensible as well.

That seems like that should be a separate commit before this one.

Other than trailing whitespace, patches 1 and 2 are:

Reviewed-by: Eric Anholt <[email protected]>

Attachment: pgph_XuJf12hf.pgp
Description: PGP signature

_______________________________________________
mesa-dev mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to