On Sun, Sep 28, 2014 at 4:26 PM, Matt Turner <matts...@gmail.com> wrote: > These checks were intended for Gen 7 only. None of these restrictions > apply to Gen 8. > --- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > index 8e4a25a..e1f5735 100644 > --- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > +++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp > @@ -648,7 +648,7 @@ fs_visitor::visit(ir_expression *ir) > } > break; > case ir_binop_imul_high: { > - if (brw->gen >= 7) > + if (brw->gen == 7) > no16("SIMD16 explicit accumulator operands unsupported\n"); > > struct brw_reg acc = retype(brw_acc_reg(), this->result.type); > @@ -684,7 +684,7 @@ fs_visitor::visit(ir_expression *ir) > emit_math(SHADER_OPCODE_INT_QUOTIENT, this->result, op[0], op[1]); > break; > case ir_binop_carry: { > - if (brw->gen >= 7) > + if (brw->gen == 7) > no16("SIMD16 explicit accumulator operands unsupported\n"); > > struct brw_reg acc = retype(brw_acc_reg(), BRW_REGISTER_TYPE_UD); > @@ -694,7 +694,7 @@ fs_visitor::visit(ir_expression *ir) > break; > } > case ir_binop_borrow: { > - if (brw->gen >= 7) > + if (brw->gen == 7) > no16("SIMD16 explicit accumulator operands unsupported\n"); > > struct brw_reg acc = retype(brw_acc_reg(), BRW_REGISTER_TYPE_UD); > -- > 1.8.5.5 > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Just FYI, I think I copied a lot of this code into the NIR frontend, so this will probably have to be fixed there too... _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev