Francisco Jerez <curroje...@riseup.net> writes: > EdB <edb+m...@sigluy.net> writes: > >> std::pair is not c++98/c++11 safe >> --- >> src/gallium/state_trackers/clover/util/compat.hpp | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/src/gallium/state_trackers/clover/util/compat.hpp >> b/src/gallium/state_trackers/clover/util/compat.hpp >> index 7305577..dd20ef0 100644 >> --- a/src/gallium/state_trackers/clover/util/compat.hpp >> +++ b/src/gallium/state_trackers/clover/util/compat.hpp >> @@ -380,6 +380,12 @@ namespace clover { >> mutable vector<char> v; >> }; >> >> + template<class T1, class T2> > > Please use "typename" instead of "class" in template arguments for > consistency. > >> + struct pair { > > A default constructor would be useful here. >
Hmm, or maybe a two-argument constructor initializing both members instead, in order to make possible a small clean-up for PATCH 3 that I'll propose in a minute. > Other than that this looks good. > >> + T1 first; >> + T2 second; >> + }; >> + >> template<typename T> >> bool >> operator==(const vector_ref<T> &a, const vector_ref<T> &b) { >> -- >> 2.1.1 >> >> _______________________________________________ >> mesa-dev mailing list >> mesa-dev@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
pgpZPVJCDRLg8.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev