On Thu, Feb 5, 2015 at 2:48 AM, Matt Turner <matts...@gmail.com> wrote: > On Wed, Feb 4, 2015 at 11:27 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >> From: Dave Airlie <airl...@gmail.com> >> >> This is a helper to return if a type is based on a double. >> >> v2: GLboolean->bool (Ian) >> >> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com> >> Signed-off-by: Dave Airlie <airl...@redhat.com> >> --- >> src/mesa/program/prog_parameter.h | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/src/mesa/program/prog_parameter.h >> b/src/mesa/program/prog_parameter.h >> index 6b3b3c2..bcbe142 100644 >> --- a/src/mesa/program/prog_parameter.h >> +++ b/src/mesa/program/prog_parameter.h >> @@ -151,6 +151,28 @@ _mesa_lookup_parameter_constant(const struct >> gl_program_parameter_list *list, >> const gl_constant_value v[], GLuint vSize, >> GLint *posOut, GLuint *swizzleOut); >> >> +static INLINE bool mesa_type_is_double(int dataType) > > Other places in this file we use 'inline' so it's safe to use here. > > Since it is static, I don't think we need the 'mesa_' prefix, but if > we want the prefix shouldn't it start with an underscore?
Well, it's static inline. Kind of at the border between having the _mesa and not. I'm opting for adding the _ to it, which is consistent with the "function defined in another file" logic (even though it's #included). _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
